-
Couldn't load subscription status.
- Fork 1.4k
Updated expired UI Test certificate. Expires 9/8/2023. #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the package identity strings in the UI Test cs file, see here: https://github.com/CommunityToolkit/WindowsCommunityToolkit/pull/4752/files#diff-0b322e99a0407123781aa69647ae087fef5cb2c536ba9ef787bbf8461838a37d (there my be others, do a quick search)
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
|
We should squash this one |
|
Ah, suppose I should try running locally in VS as well to be sure. But I think the changes should be fine. If they run in TAEF in the CI then they should run locally from the commandline as well. (And don't remember if TAEF is the only one that needs the cert anyway.) |
|
Needs 1 more approving review, or an admin override. This PR unblocks several other PRs. |
Fixes #4759
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements: