Skip to content

Conversation

@Arlodotexe
Copy link
Member

Fixes #4759

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Sep 8, 2022

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi September 8, 2022 16:30
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Sep 8, 2022
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the package identity strings in the UI Test cs file, see here: https://github.com/CommunityToolkit/WindowsCommunityToolkit/pull/4752/files#diff-0b322e99a0407123781aa69647ae087fef5cb2c536ba9ef787bbf8461838a37d (there my be others, do a quick search)

@ghost
Copy link

ghost commented Sep 8, 2022

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

@Arlodotexe
Copy link
Member Author

We should squash this one

@michael-hawker
Copy link
Member

michael-hawker commented Sep 8, 2022

Ah, suppose I should try running locally in VS as well to be sure. But I think the changes should be fine. If they run in TAEF in the CI then they should run locally from the commandline as well. (And don't remember if TAEF is the only one that needs the cert anyway.)

@ghost ghost removed the needs attention 👋 label Sep 8, 2022
@Arlodotexe
Copy link
Member Author

Needs 1 more approving review, or an admin override. This PR unblocks several other PRs.

@Arlodotexe Arlodotexe merged commit fdaef47 into main Sep 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/expired-ui-test-cert branch September 8, 2022 21:37
@michael-hawker michael-hawker added this to the 7.1.3 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 testing 🏗️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UITest PFX Expired

3 participants