Skip to content

Conversation

@Avid29
Copy link
Contributor

@Avid29 Avid29 commented Mar 23, 2022

Fixes #4519

Adds a FlowDirection override to the RadialGauge default style. This is because RTL cultures still read gauges clockwise.

The flow direction can still be explicitly overridden if desired for whatever reason.

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

RadialProgressBar and RadialGauge directions unnecessarily inversed in RTL context.

What is the new behavior?

RadialProgressBar and RadialGauge directions no longer inversed unless FlowDirection is explicitly set.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@ghost
Copy link

ghost commented Mar 23, 2022

Thanks Avid29 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker March 23, 2022 12:43
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 23, 2022
@michael-hawker michael-hawker added this to the 8.0 milestone Mar 23, 2022
@michael-hawker michael-hawker merged commit 4df3d51 into CommunityToolkit:main Jul 14, 2022
@Avid29 Avid29 deleted the Radial-RTL_override branch August 3, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavior with FlowDirection RTL for RadialProgressBar and RadialGauge

3 participants