Merged
Conversation
benceruleanlu
commented
Apr 24, 2025
benceruleanlu
commented
Apr 24, 2025
benceruleanlu
commented
Apr 24, 2025
benceruleanlu
commented
Apr 24, 2025
dosubot
bot
added
size:L
webfiltered
reviewed
Apr 25, 2025
Contributor
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
Awesome, thank you! Has this been tested on Windows + NVIDIA yet? Would like to know if there is any impact for existing installs that get pip package updates / require auto-updates.
In small part because there have been reports of uv not being perfectly predictable. That might be down to specific user configurations / firewalls.
Member
Author
Testing right now. |
webfiltered
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpu and macos are not on pytorch 2.7, but that's intended
Resolves #1115
┆Issue is synchronized with this Notion page by Unito