Skip to content

Remove automatic nightly pytorch for blackwell users on desktop#3613

Merged
benceruleanlu merged 3 commits intomainfrom
bcl1
Apr 25, 2025
Merged

Remove automatic nightly pytorch for blackwell users on desktop#3613
benceruleanlu merged 3 commits intomainfrom
bcl1

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Apr 24, 2025

Truly, a tear is to be shed.

We no longer need to force nightly on blackwell users.

TorchMirrorUrl.NightlyCuda, however, lives on.

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner April 24, 2025 22:37
@benceruleanlu benceruleanlu marked this pull request as draft April 24, 2025 22:37
@benceruleanlu
Copy link
Member Author

Waiting for types publish from Comfy-Org/desktop#1126.

@benceruleanlu benceruleanlu changed the title Remove forced nightly for desktop Remove automatic nightly pytorch for blackwell users on desktop Apr 25, 2025
@benceruleanlu
Copy link
Member Author

Types are published!

@benceruleanlu benceruleanlu marked this pull request as ready for review April 25, 2025 21:45
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​comfyorg/​comfyui-electron-types@​0.4.39 ⏵ 0.4.4277 +21006695 +170

View full report

@benceruleanlu benceruleanlu merged commit 84c14dd into main Apr 25, 2025
10 checks passed
@benceruleanlu benceruleanlu deleted the bcl1 branch April 25, 2025 22:08
christian-byrne pushed a commit that referenced this pull request May 20, 2025
Co-authored-by: Benjamin Lu <templu1107@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants