Merge main into vue-nodes-migration #5205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: snomiao <7323030+snomiao@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>
…ent (#4852) Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Actually, this probably should be done closer to the time we want to merge vue nodes into main? |
* [ci] Make Playwright deploy step safe to fail Add continue-on-error: true to Deploy to Cloudflare Pages step to prevent Cloudflare API issues from blocking essential testing processes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [ci] Make lint-and-format comment steps safe to fail Add continue-on-error: true to PR comment steps in lint workflow: - Comment on PR about auto-fix (line 63) - Comment on PR about manual fix needed (line 76) This prevents GitHub API permission errors from blocking essential linting processes while maintaining comment functionality. --------- Co-authored-by: Claude <noreply@anthropic.com>
* feat: Add dropdown list for additional tabs * fix: workflow menu and tabs styles
* [ci] Enhance CI/CD caching across all workflows - Add tool cache steps for node_modules/.cache, .cache, and .eslintcache - Enable npm caching for Node.js setup actions where missing - Add cache configurations for ESLint, Prettier, Knip, and other build tools - Improve build performance by caching tool outputs between runs - Use unique cache keys per workflow to avoid conflicts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [ci] Enhance CI/CD caching with comprehensive improvements Extends caching strategy beyond PR #5107 with additional optimizations: - **i18n.yaml**: Add tool cache for locale generation workflow - **update-electron-types.yaml**: Add tool cache for type updates - **test-ui.yaml**: Add Playwright browser cache and Python pip cache - **vitest.yaml**: Add coverage directory caching - **chromatic.yaml**: Add Storybook static build cache - **All build workflows**: Add TypeScript incremental build cache - **Type generation workflows**: Add repository caching for external repos - **lint-and-format.yaml**: Improve cache key granularity with source hash Performance improvements: - Playwright browser downloads cached across runs - Python pip dependencies cached - TSC incremental compilation cache preserved - Storybook static builds cached - External repository clones cached - More granular cache invalidation based on source changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [ci] Optimize CI/CD caching for better performance - Enhance cache keys with more specific file patterns for better cache hit rates - Add missing cache directories (.prettierCache, .knip-cache, .vitest-cache, tsconfig.tsbuildinfo) - Improve cache key naming for clarity (lint-format, vitest, storybook, playwright) - Add better fallback cache restore keys - Include browser-specific caching for Playwright tests - Add TypeScript build info caching across workflows Expected improvements: - 20-40% faster builds on cache hits - More granular cache invalidation - Better cache utilization across tools 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * [ci] Remove redundant node_modules/.cache from workflow caches setup-node already handles node_modules caching when cache: 'npm' is enabled. Removed conflicting node_modules/.cache entries from: - .github/workflows/lint-and-format.yaml - .github/workflows/vitest.yaml - .github/workflows/test-ui.yaml This prevents cache conflicts and follows best practices for npm caching. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Update .github/workflows/chromatic.yaml Co-authored-by: Alexander Brown <drjkl@comfy.org> * Update .github/workflows/update-electron-types.yaml Co-authored-by: Alexander Brown <drjkl@comfy.org> * fix: address reviewer feedback on cache optimization PR (#5200) * fix: remove duplicate cache entries and fix YAML formatting - Remove duplicate path entries in dev-release.yaml - Remove redundant node_modules/.cache entries since setup-node handles npm caching - Fix YAML indentation issues across workflow files Addresses reviewer feedback on PR #5117 about duplication and maintenance * fix: add cache-dependency-path for setup-node in test-ui workflow The test-ui workflow runs at repo root but package-lock.json is in ComfyUI_frontend/ subdirectory, causing setup-node cache to fail. Added cache-dependency-path to fix this. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
* Add Gemini Image node static pricing * Update locales [skip ci] --------- Co-authored-by: github-actions <github-actions@github.com>
The refreshComboInNodes function was only iterating over top-level nodes, missing nodes inside subgraphs. This caused file lists and combo widget options to not update properly when new models were added, unless users created completely new nodes. Changes: - Replace graph.nodes iteration with forEachNode() for hierarchical traversal - Import forEachNode utility from graphTraversalUtil - Change early continue to early return for callback function Fixes #5196 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
* migration: npm to pnpm Step 1, package and lockfile * migration: npm to pnpm Step 2: docs / LLM instructions * migration: npm to pnpm Step 3: More documentation updates * migration: npm to pnpm Step 4: Even more documentation * migration: npm to pnpm Step 5: GitHub Actions * migration: npm to pnpm Step 6: PNPM installation in actions. This merge is going to be painful. * migration: npm to pnpm Unignore and add pnpm lockfile. * migration: npm to pnpm package-lock.json -> pnpm-lock.yaml * migration: explicit @primeuix/styled, move glob to prod deps * migration: more explicit deps required by the importmap plugin and vite * fix: missed merge artifact * fix: Make sure pnpm is available to install wrangler * migration: pnpm for dev-release.yaml * migration: new setup action version Won't work until that is updated and a new release is cut. * migration: Playwright needs uuid * migration: Add explicit deps for lobehub * chore(version-bump.yaml): change cache from npm to pnpm to optimize package management and improve build performance * migration: install pnpm in version-bump action --------- Co-authored-by: snomiao <snomiao@gmail.com>
…5137) * [fix] Correct WhatsNew popup arrow alignment with help center icon The arrow positioning was not accounting for additional sidebar icons (terminal and shortcuts) that were added below the help center icon, causing misalignment. Updated the calculation to properly position the arrow relative to the help center icon's current location. Fixes #5126 * [fix] Update small sidebar arrow positioning and improve center alignment - Fixed small sidebar rule to use consistent calculation with normal sidebar - Updated positioning to use half icon height for better center alignment - Both normal and small sidebar now use dynamic CSS variable calculations Addresses feedback from review by viva-jinyi on CSS specificity and positioning accuracy. * [fix] Make sidebar CSS variables global for teleported components - Move --sidebar-width CSS variable to :root to make it accessible globally - This allows teleported components like WhatsNewPopup to reference sidebar dimensions - Adjust arrow positioning calculations for better alignment with help center icon - Add explanatory comments about why these variables need to be global 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: icon-size should be variable --------- Co-authored-by: Jin Yi <jin12cc@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
* [feat] Move i18n workflow to release-only pattern - Modify i18n.yaml to only run on version-bump-* branches and manual dispatch - Follow chromatic.yaml pattern for release-only workflows - Update CONTRIBUTING.md to document new translation process - Reduces PR conflicts and improves development velocity Fixes #5224 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [feat] Optimize i18n workflow trigger conditions Move logic from job-level 'if' to more restrictive trigger configuration: - Limit pull_request trigger to main/master branches only - Add explicit types to reduce unnecessary workflow runs - Simplify job-level condition while maintaining same behavior - Only run on version-bump-* branches or manual dispatch * Apply suggestion from @DrJKL Co-authored-by: Alexander Brown <drjkl@comfy.org> * [feat] Optimize i18n workflow trigger conditions - Simplify trigger section with cleaner organization - Move workflow_dispatch to top for better readability - Remove unnecessary path-ignore filters - Add clearer comments for branch detection logic - Maintain same functional behavior while improving structure Addresses request to move branch detection logic from job-level 'if' to trigger-level 'on' where possible within GitHub Actions limitations. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com>
…5229) Update the GitHub workflow to use ComfyUI's animated favicon progress frames instead of the Claude logo for PR test status comments.
* fix: animation state handling * fix: animation timing * refator: remove out of scope changes * refactor: remove unused types * fix: animation timing * fix: animation properties * refactor: remove unneeded transaltez/3d hack because we dont support safari * refactor: pr feedback * consistent translate functions * Update test expectations [skip ci] * Remove EditModelButton * fix: update toolbox position test bounds --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
Add strict Slack-compatible template with specific formatting requirements to eliminate format variations in marketing notifications.
- Add pnpm outdated for dependency analysis - Include pnpm licenses for compliance checking - Use pnpm why for dependency tree analysis - Add pnpm doctor for health checks - Replace npm audit with pnpm audit These additions provide better insights during release process and leverage pnpm's superior dependency analysis tools. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
…elected node group (#4156)
|
The time of merge being this friday... |
dosubot
bot
added
the
size:XXL
|
Will be removing COMFY_VUE_NODE_DIMENSIONS (before merge) as we allow vue nodes to place slots anywhere on vue-nodes-migration, but it will exist in the test snapshots for this branch |
christian-byrne
approved these changes
Aug 28, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of main into vue-nodes-migration
This PR merges the latest changes from main into the vue-nodes-migration branch.
What was done:
Merge conflicts resolved in:
Important notes:
This is a standard merge to keep the feature branch up to date with main.
┆Issue is synchronized with this Notion page by Unito