Fix/toolbox animation #5197
Open
Fix/toolbox animation #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results❌ Some tests failed! ⏰ Completed at: 08/27/2025, 01:31:07 AM UTC 📊 Test Reports by Browser
|
DrJKL
reviewed
Aug 25, 2025
simula-r
force-pushed
the
fix/toolbox-animation
branch
from
eb70ad1 to
d65305e
Compare
DrJKL
previously approved these changes
Aug 25, 2025
DrJKL
added
the
New Browser Test Expectations
|
Letting the Playwright screenshots update, then I think this is good to go. |
DrJKL
reviewed
Aug 26, 2025
...ionToolbox.spec.ts-snapshots/selection-toolbox-single-selection-no-border-chromium-linux.png
Outdated
Show resolved
Hide resolved
DrJKL
reviewed
Aug 26, 2025
...ionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png
Outdated
Show resolved
Hide resolved
DrJKL
force-pushed
the
fix/toolbox-animation
branch
from
3dc6d2d to
2babe32
Compare
dosubot
bot
added
the
size:M
christian-byrne
requested changes
Aug 26, 2025
DrJKL
reviewed
Aug 26, 2025
github-actions
bot
requested review from
Yorha4D,
KarryCharon and
shinshin86
as code owners
DrJKL
force-pushed
the
fix/toolbox-animation
branch
from
f39e36c to
f4586bf
Compare
DrJKL
added
New Browser Test Expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed broken animation for toolbox, essentially came down to using v-if to allow for animation leave keyframes via unmount lifecycle. Removed need for inject() and other unneeded state management as we have already have
visiblestate.Screenshots (if applicable)
fix-toolbar-animation.mp4