Conversation
christian-byrne
left a comment
There was a problem hiding this comment.
Could you add a unit test and demo recording if possible?
|
For anyone else: To test this feature, you need to do this in ComfyUI folder: git remote add jtydhr88 https://github.com/jtydhr88/ComfyUI.git
git fetch jtydhr88
git checkout -b record-audio-node jtydhr88/record-audio-node |
christian-byrne
left a comment
There was a problem hiding this comment.
Nice, this looks ready to merge. The only two minor things I would say are:
- Is it possible to replace timeout with hard-coded 500ms with somthing that resolves on
mediaRecorder.onStop(or similar)? - Could we remove the
console.logs?
|
@christian-byrne fixed your feedback, please double check |
|
there is one failed test about locale, likely not caused by this change |
089a10f to
d5d3b83
Compare
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Bounty task - audio input node, requested in https://www.notion.so/drip-art/Audio-input-node-1706d73d365080eeb8e5e39790584dff?source=copy_link
Need BE change here Comfy-Org/ComfyUI#8716
Please notice I introdcued two new dependencies to support record audio:
the reason of why I need this two is, as practised, the native browser MediaRecorder API has significant limitations for our use case:
so we need to use this extendable-media-recorder could allow us record WAV directly.
┆Issue is synchronized with this Notion page by Unito