Conversation
jtydhr88
requested review from
Kosinkadink,
christian-byrne,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
|
|
||
| RETURN_TYPES = ("AUDIO", ) | ||
| FUNCTION = "load" | ||
|
|
There was a problem hiding this comment.
Note for any other reviewers (or future me): Because the uploaded files are named via timestamps by the frontend, an existing uploaded audio file should never be updated. That's why we don't need the IS_CHANGED here.
|
@OrangeDoro hi, the main issue of your LLM feedback is lacking some context, for this specific case, it could not only consider this single PR, as it also has FE part, the full feature required both BE (this) and FE, such as how we handle upload recoding to temp folder. BTW, I don’t want to confuse the core team reviewer as we already approve this BE changes, and it is close to merge soon, could you remove your LLM feedback? if you want to share your study, you can email me directly with these information - wswdkt88@gmail.com |
|
@guill @comfyanonymous @christian-byrne As we already merge FE Comfy-Org/ComfyUI_frontend#4289, please make sure we have this PR while include the latest FE |
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
This is good to merge now, as the frontend support has been added.
* record audio node * sf
* record audio node * sf
* record audio node * sf
4 participants
BE changes for bounty task https://www.notion.so/drip-art/Audio-input-node-1706d73d365080eeb8e5e39790584dff?source=copy_link
and FE changes is here