Fix module name for comfy extra nodes#3943
Closed
huchenlei wants to merge 1 commit intoComfy-Org:masterfrom
Closed
Fix module name for comfy extra nodes#3943huchenlei wants to merge 1 commit intoComfy-Org:masterfrom
huchenlei wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #3936
The code was originally added by 8c4ccb5
The original PR does not explain the operation on module name. I believe the original intention here is to drop the '.py' file extension on module_name. However, the original code does this on full 'module_path', which resulted
cls.__module__being set to full file path.