Add python_module to node info#3936
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom Jul 9, 2024
Merged
Conversation
Member
Contributor
Author
The full path comes from the loading of modules with abs path here: https://github.com/comfyanonymous/ComfyUI/blob/24b969d3dace581ed3fb547eedfbdf502ad0f7e9/nodes.py#L1974-L2018 I will fix it so that we can have consistent |
Use more explicit name 'python_module' Parse abs ath Move parse to nodes.py
Contributor
Author
|
@comfyanonymous Can you take a look again? I have fixed module names passed to frontend to be relative module name against ComfyUI root. The change does not affect current module loading. |
csokun
pushed a commit
to csokun/ComfyUI
that referenced
this pull request
Jul 10, 2024
Use more explicit name 'python_module' Parse abs ath Move parse to nodes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR add node class's
RELATIVE_PYTHON_MODULEto node def object returned by/object_infoAPI endpoint.RELATIVE_PYTHON_MODULEis the relative python module path against the project root, e.g.custom_nodes.fooThis will help show the node belongs to which custom node pack in the redesigned node search box. Comfy-Org/ComfyUI_frontend#83
How to verify
cd tests-ui/npm inpm test:generatetests-ui/data/object_info.jsonSome examples:
Built-in node
Custom node