Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe-block test case and detector #38

Merged
merged 31 commits into from
Dec 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
20fda2f
Added unsafe-block test case
faculerena Nov 30, 2023
80c2fb7
Merge branch 'main' into unsafe-block
faculerena Dec 1, 2023
6317856
first iteration of unsafe-block detector
faculerena Dec 1, 2023
fff536b
change name on impl
faculerena Dec 1, 2023
faccbfd
cargo fmt
faculerena Dec 4, 2023
64c77b5
changed core-mem-forget to avoid-..
faculerena Dec 6, 2023
1a993ac
changed unsafe-block to avoid-*
faculerena Dec 6, 2023
ddf57e3
Update test-detectors.yml
faculerena Dec 6, 2023
ec9dab0
merge main
faculerena Dec 6, 2023
f3d866b
Merge branch 'core-mem-forget' of github.com:CoinFabrik/scout-soroban…
faculerena Dec 6, 2023
42981d8
Merge branch 'main' into core-mem-forget
faculerena Dec 6, 2023
d92a8f8
Merge branch 'main' into unsafe-block
faculerena Dec 6, 2023
4b10b56
forgot one name
faculerena Dec 6, 2023
c413c80
Merge branch 'core-mem-forget' of github.com:CoinFabrik/scout-soroban…
faculerena Dec 6, 2023
b570602
removed old name
faculerena Dec 6, 2023
a0baa26
package names
faculerena Dec 6, 2023
b667b5c
dup
faculerena Dec 6, 2023
c44d96e
dup
faculerena Dec 6, 2023
6aeec54
dup again
faculerena Dec 6, 2023
3035dfa
merge next branch
faculerena Dec 6, 2023
7a8c93c
changed to avoid-
faculerena Dec 6, 2023
27e64ed
detector fix
faculerena Dec 7, 2023
d3f4992
removed file
faculerena Dec 7, 2023
8a8b180
wrong folder name
faculerena Dec 7, 2023
104917e
detectors should be in alphabetical order or CI fails
faculerena Dec 7, 2023
6e0ab3a
Merge branch 'main' into unsafe-block
arlosiggio Dec 12, 2023
81be4eb
remove redefine in lint_message.rs
arlosiggio Dec 12, 2023
7a4eb6c
Merge branch 'main' into unsafe-block
faculerena Dec 15, 2023
e7c9f71
review changes
faculerena Dec 20, 2023
70bc352
Merge branch 'main' into unsafe-block
faculerena Dec 20, 2023
b6018a6
Update lint_message.rs
faculerena Dec 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lint_message.rs
  • Loading branch information
faculerena authored Dec 20, 2023
commit b6018a6d38087616fe33abcdb1da2cb4fe825b07
2 changes: 0 additions & 2 deletions scout-audit-internal/src/detector/lint_message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ pub const DIVIDE_BEFORE_MULTIPLY_LINT_MESSAGE: &str =
"Division before multiplication might result in a loss of precision";
pub const DOS_UNBOUNDED_OPERATION_LINT_MESSAGE: &str =
"In order to prevent a single transaction from consuming all the gas in a block, unbounded operations must be avoided";
pub const INSUFFICIENTLY_RANDOM_VALUES_LINT_MESSAGE: &str =
"Use env.prng() to generate random numbers, and remember that all random numbers are under the control of validators";
pub const OVERFLOW_CHECK_LINT_MESSAGE: &str = "Use `overflow-checks = true` in Cargo.toml profile";
pub const SET_CONTRACT_STORAGE_LINT_MESSAGE:&str = "Abitrary users should not have control over keys because it implies writing any value of left mapping, lazy variable, or the main struct of the contract located in position 0 of the storage";
pub const UNPROTECTED_UPDATE_CURRENT_CONTRACT_LINT_MESSAGE: &str =
Expand Down