changed core-mem-forget to avoid-..

.github/workflows/test-detectors.yml

@@ -97,7 +97,7 @@ jobs:
           - macos-latest
         test:
           [
-            "core-mem-forget",
+            "avoid-avoid-avoid-core-mem-forget",
             "divide-before-multiply",
             "overflow-check",
             "unprotected-update-current-contract-wasm",

detectors/core-mem-forget/src/lib.rs → detectors/avoid-core-mem-forget/src/lib.rs

@@ -41,18 +41,18 @@ dylint_linting::impl_pre_expansion_lint! {
     ///    }
     ///```
 
-    pub CORE_MEM_FORGET,
+    pub AVOID_CORE_MEM_FORGET,
     Warn,
-    Detector::CoreMemForget.get_lint_message(),
-    CoreMemForget::default()
+    Detector::AvoidCoreMemForget.get_lint_message(),
+    AvoidCoreMemForget::default()
 }
 
 #[derive(Default)]
-pub struct CoreMemForget {
+pub struct AvoidCoreMemForget {
     stack: Vec<NodeId>,
 }
 
-impl EarlyLintPass for CoreMemForget {
+impl EarlyLintPass for AvoidCoreMemForget {
     fn check_item(&mut self, _cx: &EarlyContext, item: &Item) {
         if self.in_test_item() || is_test_item(item) {
             self.stack.push(item.id);
@@ -70,9 +70,9 @@ impl EarlyLintPass for CoreMemForget {
             if path.segments[2].ident.name.to_string() == "forget";
             then {
 
-                Detector::CoreMemForget.span_lint_and_help(
+                Detector::AvoidCoreMemForget.span_lint_and_help(
                     cx,
-                    CORE_MEM_FORGET,
+                    AVOID_CORE_MEM_FORGET,
                     expr.span,
                     "Instead, use the `let _ = ...` pattern or `.drop` method to forget the value.",
                 );
@@ -102,7 +102,7 @@ fn is_test_item(item: &Item) -> bool {
     })
 }
 
-impl CoreMemForget {
+impl AvoidCoreMemForget {
     fn in_test_item(&self) -> bool {
         !self.stack.is_empty()
     }

scout-audit-internal/src/detector.rs

@@ -38,7 +38,7 @@ impl Detector {
     /// Returns the lint message for the detector.
     pub const fn get_lint_message(&self) -> &'static str {
         match self {
-            Detector::CoreMemForget => CORE_MEM_FORGET_LINT_MESSAGE,
+            Detector::AvoidCoreMemForget => AVOID_CORE_MEM_FORGET_LINT_MESSAGE,
             Detector::DivideBeforeMultiply => DIVIDE_BEFORE_MULTIPLY_LINT_MESSAGE,
             Detector::UnsafeExpect => UNSAFE_EXPECT_LINT_MESSAGE,
             Detector::OverflowCheck => OVERFLOW_CHECK_LINT_MESSAGE,

scout-audit-internal/src/detector/lint_message.rs

@@ -1,4 +1,4 @@
-pub const CORE_MEM_FORGET_LINT_MESSAGE: &str =
+pub const AVOID_CORE_MEM_FORGET_LINT_MESSAGE: &str =
     "Use the `let _ = ...` pattern or `.drop()` method to forget the value";
 pub const DIVIDE_BEFORE_MULTIPLY_LINT_MESSAGE: &str =
     "Division before multiplication might result in a loss of precision";

test-cases/core-mem-forget/core-mem-forget-1/remediated-example/src/lib.rs → test-cases/avoid-core-mem-forget/avoid-core-mem-forget-1/remediated-example/src/lib.rs

@@ -2,7 +2,7 @@
 use soroban_sdk::{contract, contractimpl, contracttype};
 
 #[contract]
-pub struct CoreMemForget;
+pub struct AvoidCoreMemForget;
 
 #[contracttype]
 #[derive(Eq, PartialEq)]
@@ -12,7 +12,7 @@ pub struct WithoutCopy {
 }
 
 #[contractimpl]
-impl CoreMemForget {
+impl AvoidCoreMemForget {
     pub fn forget_something(n: WithoutCopy) -> u64 {
         let _ = n;
         0
@@ -27,7 +27,7 @@ mod tests {
     fn test_forget_something() {
         let test_value: WithoutCopy = WithoutCopy { a: 80, b: 60 };
 
-        let result = CoreMemForget::forget_something(test_value);
+        let result = AvoidCoreMemForget::forget_something(test_value);
 
         assert_eq!(result, 0);
     }

test-cases/core-mem-forget/core-mem-forget-1/vulnerable-example/src/lib.rs → test-cases/avoid-core-mem-forget/avoid-core-mem-forget-1/vulnerable-example/src/lib.rs

@@ -2,7 +2,7 @@
 use soroban_sdk::{contract, contractimpl, contracttype};
 
 #[contract]
-pub struct CoreMemForget;
+pub struct AvoidCoreMemForget;
 
 #[contracttype]
 #[derive(Eq, PartialEq)]
@@ -12,7 +12,7 @@ pub struct WithoutCopy {
 }
 
 #[contractimpl]
-impl CoreMemForget {
+impl AvoidCoreMemForget {
     pub fn forget_something(n: WithoutCopy) -> u64 {
         core::mem::forget(n);
         0
@@ -27,7 +27,7 @@ mod tests {
     fn test_forget_something() {
         let test_value: WithoutCopy = WithoutCopy { a: 80, b: 60 };
 
-        let result = CoreMemForget::forget_something(test_value);
+        let result = AvoidCoreMemForget::forget_something(test_value);
 
         assert_eq!(result, 0);
     }