Delete, Delete in range and Move implemented

[AndreAzevedoCoder]

#8
Added Delete, Delete in Range and Move a point(or a rectangle/circle).
It's pretty simple and maybe not optimized.
Hope it helps someone that just like me need it for a game or something like that.

[crhallberg]

This looks really good! Would it be possible to write a test or two for these changes?

[crhallberg]

It looks like below you're using the userData of each Point to store an id. Is userData on a Rectangle part of it that I didn't see?

[crhallberg]

I think this just needs to be removed because it's not being used in the code that I can see.

[crhallberg]

One approach I like for deleting from an array is to loop backwards thru an array to get around the index changes. Just a tip!

[crhallberg]

I had a recommendation to simplify this a bit by running backwards thru the array:

 for( var i = this.points.length; i--;){
    var p = this.points[i];
    if (range.contains(p)) {
      this.points.splice(i, 1);
    }
}

With ES6 we can now try to use a filter, which might be cleaner and faster!

[crhallberg]

Hey! I've gotten upgraded permissions to the repository so I'm trying to do some clean up! Any interest in getting this up to date?

[AndreAzevedoCoder]

Of course! What can I do?

[crhallberg]

Great! Step 1 is merging with main and fixing conflicts.

After that, I think we left it with two comments that need addressing and missing some tests.

Are there any parts of this you want me to tackle?

[crhallberg]

I've been thinking about this a lot and I think this approach needs some tweaks. Since the QuadTree isn't providing the IDs, I'm skeptical about relying on IDs for deleting points. Also based on this usage guide for a different implementation of QuadTrees, QuadTrees are more useful to be snapshots and not live systems.

Here's what I propose (and will implement with help from your great code above):

• deleteFromRange(range): as you've done so.
• filter(fn): takes a function and returns a new QuadTree built with all true points inserted. This allows for a lot of reuse of what we have and will return a tree with no empty quads or subdivisions.
• clear(): as requested in Function to clear QuadTree #9.

[crhallberg]

Incorporated into #62, now merged.