Skip to content

Restore API compatibility for Settings.fillFromJson #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 1 commit into from
Nov 3, 2021
Merged

Restore API compatibility for Settings.fillFromJson #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { DisplaySettings } from '@src/DisplaySettings';
import { ImporterSettings } from '@src/ImporterSettings';
import { FingeringMode, NotationMode, NotationSettings, NotationElement } from '@src/NotationSettings';
import { PlayerSettings } from '@src/PlayerSettings';
import { SettingsSerializer } from '@src/generated/SettingsSerializer';

/**
* This public class contains instance specific settings for alphaTab
Expand Down Expand Up @@ -57,4 +58,11 @@ export class Settings {
settings.setSongBookModeSettings();
return settings;
}

/**
* @target web
*/
public fillFromJson(json: any): void {
SettingsSerializer.fromJson(this, json);
}
}