Skip to content

Restore API compatibility for Settings.fillFromJson #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 1 commit into from
Nov 3, 2021
Merged

Restore API compatibility for Settings.fillFromJson #676

Danielku15 merged 1 commit into from
Nov 3, 2021

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 3, 2021

Issues

Fixes #674

Proposed changes

Re-add the method from alphaTab 1.1 which allowed filling an existing Settings object from a given JSON object.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 3, 2021
@Danielku15 Danielku15 merged commit ee308e1 into develop Nov 3, 2021
@Danielku15 Danielku15 deleted the feature/fill-from-json branch November 3, 2021 16:27
@Danielku15 Danielku15 mentioned this pull request Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore API compatibility for Settings.fillFromJson

2 participants

@Danielku15