Skip to content

Respect ties correctly in overflows #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 4 commits into from
Oct 9, 2022
Merged

Respect ties correctly in overflows #1002

Danielku15 merged 4 commits into from
Oct 9, 2022

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Oct 8, 2022

Issues

Fixes #688

Proposed changes

  • Let ties register themselves into bar renderer overflows

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Oct 8, 2022
@Danielku15 Danielku15 merged commit 77c26ee into develop Oct 9, 2022
@Danielku15 Danielku15 deleted the feature/cropped-ties branch October 9, 2022 11:52
ChiHoc pushed a commit to ChiHoc/alphaTab that referenced this pull request Nov 7, 2022
@Danielku15 @ChiHoc
Respect ties correctly in overflows (CoderLine#1002)
e976dba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ties are cut off on raster graphics

2 participants

@Danielku15