-
Notifications
You must be signed in to change notification settings - Fork 5
Support for full PHPUnit public API #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Separate methods inherited from the PHPUnit library to an individual trait for clarity and maintainability added documentation via PHP annotations
It is difficult to see what methods were added, because you refactored in the same commit. |
Done! 😃 You can see the changes here. All were added assertions.
Because they were deprecated and eliminated. @Naktibalda I'll be very aware of your comments. Cheers! |
|
||
protected function assertStringContainsString($needle, $haystack, $message = '') | ||
{ | ||
TestCase::assertStringContainsString($needle, $haystack, $message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, you removed my wrapper methods here, so they are broken with older versions of PHPUnit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, It wasn't my intention, but I'm glad it could be fixed, thanks you
Info: we use Codeception 4.0.x with PHPUnit 7.5.x, because of dependency in codeception ^1.0 of this package and the removal of the two mentioned assertions, pipeline fails now. Because we don't have the time to upgrade to PHPUnit at the moment I think we have to pin to version 1.12.x now. |
@brainformatik that issue was fixed in lib-asserts 1.13.1, you can upgrade it now. |
@Naktibalda thanks for quick response, I saw the updated version, but error persists:
Error comes from module-asserts which we use. |
I released 1.3.0 of module-asserts too. |
Thanks, with that it's working again. |
Uh oh!
There was an error while loading. Please reload this page.