Refactoring work for code quality #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith some invalid data. Divide and conquer: Divided the verifiers into traits depending on the type of data they verify. Improved code quality and maintainability. used strict types and namespaces. Added documentation for all verifiers in order to allow in a future commit to generate the complete API documentation for publication on the codeception page. Added data validations with php issers functions. [BC] Removed 'equalXMLStructure()' and its corresponding test since its code is deprecated [BC] Removed support for PHP 7.0 and its corresponding versions of phpunit and phpunit-wrapper, since the use of features available since PHP 7.1 was required and will be required, among which the is_iterable () function, nullable types, among others.
|
Wow, this seems a really good piece of work! Thank you! Let's wait for @Naktibalda's review and if everything fine we can merge this and release a new major version. |
DavertMik
approved these changes
Aug 27, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Quality:
Divide and conquer:
Preparing for the future:
What's Next:
Continuing the work started in:
As soon as the changes are merged, I will proceed to:
NOTE: This should be tagged as a new release, to allow users using PHP 7.0 and PHPUnit 6.x to stay on version 1.3.x to work with the library as before.
@Naktibalda waiting for review.