-
-
Notifications
You must be signed in to change notification settings - Fork 219
NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-stretch #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 14 commits
9d43b8b
b0265ba
f1ac2fe
78b6e92
1b11c5a
596bf65
bfae2f8
4eb2d5b
9c8e884
f0d7b15
d5d16fa
5a7757f
9447d08
791b52a
70f9400
c1efb3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
function creditCardValidator(cardNumber) { | ||
// declare the length of valid card number | ||
const VALID_LENGTH = 16; | ||
|
||
// Remove all - and spaces from the input | ||
const sanitized = cardNumber.replace(/[-\s]/g, ""); | ||
|
||
//check if the length of the sanitized input is 16 | ||
if (sanitized.length !== VALID_LENGTH) { | ||
return false; | ||
} | ||
// check if the sanitized input contains only digits | ||
if (!new RegExp(`^\\d{${VALID_LENGTH}}$`).test(sanitized)) { | ||
return false; | ||
} | ||
|
||
// check if there ara at least two different digits | ||
const uniqueDigits = new Set(sanitized); | ||
if (uniqueDigits.size < 2) { | ||
return false; | ||
} | ||
|
||
// check if the last digit is even | ||
const lastDigit = Number(sanitized[sanitized.length - 1]); | ||
if (lastDigit % 2 !== 0) { | ||
return false; | ||
} | ||
|
||
// check if the sum of all digits is greater than 16 | ||
const sum = sanitized | ||
.split("") | ||
.reduce((total, digit) => total + Number(digit), 0); | ||
if (sum <= VALID_LENGTH) { | ||
return false; | ||
} | ||
|
||
return true; | ||
} | ||
|
||
module.exports = creditCardValidator; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
const creditCardValidator = require("./creditCard-validator"); | ||
|
||
describe("creditCardValidator", () => { | ||
test("should return true for a 16 digit long card number", () => { | ||
expect(creditCardValidator("1234-5678-9012-3456")).toBe(true); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your tests all currently assume there are extra characters in the credit card number - is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. I should have included tests for card numbers that are more or fewer than 16 digits. As you suggested, I created one test for the case of fewer and another for more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These extra tests look good, but aren't quite getting at the problem I was pointing at - can you add a test for a 16-digit credit card number which is only numbers (i.e. no spaces or There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. I included a test for only 16 digits without spaces or operators. |
||
}); | ||
|
||
test("should return false if the card number is not digit only", () => { | ||
expect(creditCardValidator("1234-5678-abcd-3456")).toBe(false); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
|
||
test("should return false if the card number does not contain at least two different digits", () => { | ||
expect(creditCardValidator("1111-1111-1111-1111")).toBe(false); | ||
expect(creditCardValidator("1111 2222 2222 2222")).toBe(true); | ||
}); | ||
|
||
test("should return false if the card number does not end with an even digit", () => { | ||
expect(creditCardValidator("1234-5678-9012-3457")).toBe(false); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
|
||
test("should return false if the sum of all the digits is not greater than 16", () => { | ||
expect(creditCardValidator("0000-0000-0000-0000")).toBe(false); | ||
expect(creditCardValidator("1111 1111 1111 1111")).toBe(false); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
|
||
// test for less than 16 digits | ||
test("should return false for a card number with less than 16 digits", () => { | ||
expect(creditCardValidator("123456789012345")).toBe(false); | ||
expect(creditCardValidator("1234-5678-9012-345")).toBe(false); | ||
}); | ||
|
||
// test for more than 16 digits | ||
test("should return false for a card number with more than 16 digits", () => { | ||
expect(creditCardValidator("12345678901234567")).toBe(false); | ||
expect(creditCardValidator("1234-5678-9012-34567")).toBe(false); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,37 @@ | ||
function passwordValidator(password) { | ||
return password.length < 5 ? false : true | ||
} | ||
const lengthCondition = password.length >= 5; | ||
console.log(`length condition: ${lengthCondition}`); | ||
|
||
const uppercaseCondition = /[A-Z]/.test(password); | ||
console.log(`upper case condition: ${uppercaseCondition}`); | ||
|
||
const lowercaseCondition = /[a-z]/.test(password); | ||
console.log(`lower case condition: ${lowercaseCondition}`); | ||
|
||
const numberCondition = /[0-9]/.test(password); | ||
console.log(`number condition: ${numberCondition}`); | ||
|
||
const symbolCondition = /[!#$%.*&]/.test(password); | ||
console.log(`symbol condition: ${symbolCondition}`); | ||
|
||
const previousPasswords = [ | ||
|
||
"123Ab!", | ||
"abcD1#", | ||
"Password1!", | ||
"Qwerty1*", | ||
"Zxcvbnm2$", | ||
]; | ||
const notInPreviousPasswords = !previousPasswords.includes(password); | ||
console.log(`previous password condition: ${notInPreviousPasswords}`); | ||
|
||
return ( | ||
lengthCondition && | ||
uppercaseCondition && | ||
lowercaseCondition && | ||
numberCondition && | ||
symbolCondition && | ||
notInPreviousPasswords | ||
); | ||
} | ||
|
||
module.exports = passwordValidator; | ||
module.exports = passwordValidator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me that the 16 here is related to the length of the number.
We want to be careful only to extract/share code where the reason for the sharing is the same. The first two places you use
VALID_LENGTH
are definitely both about the length, but here I would either put 16 back in, or make a separate constantMINIMUM_SUM
or similar. Even though it happens to have the same value, if the reason is different, we don't want to share them. Otherwise e.g. if we changed the minimum sum, we may accidentally also change the expected length!