generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 218
NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-stretch #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TzeMingHo
wants to merge
15
commits into
CodeYourFuture:main
Choose a base branch
from
TzeMingHo:coursework/sprint-3-stretch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9d43b8b
npm installed
TzeMingHo b0265ba
answer part a in find.js
TzeMingHo f1ac2fe
answered part b to d in find.js
TzeMingHo 78b6e92
writing conditions and tests for password validation
TzeMingHo 1b11c5a
added a break line in test file
TzeMingHo 596bf65
created credit card validator file and its tests file
TzeMingHo bfae2f8
removing all space and - from the string input
TzeMingHo 4eb2d5b
created tests and function for credit card validation
TzeMingHo 9c8e884
restore package-lock.json from origin/main
TzeMingHo f0d7b15
adding a variable for card valid length
TzeMingHo d5d16fa
adding tests for card number length validation and only digit
TzeMingHo 5a7757f
updating return statement in password-validator.js
TzeMingHo 9447d08
updated password to validaPassword in tests
TzeMingHo 791b52a
adding tests for false cases
TzeMingHo 70f9400
added a test for only 16 digits with spaces or operators, updated var…
TzeMingHo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
removing all space and - from the string input
- Loading branch information
commit bfae2f8725bd7887cc51547a2967563207ef293b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,13 @@ | ||
function creditCardValidator(cardNumber) {} | ||
function creditCardValidator(cardNumber) { | ||
// Remove all - and spaces from the input | ||
const sanitized = cardNumber.replace(/[-\s]/g, ""); | ||
|
||
//check if the length of the sanitized input is 16 | ||
if (sanitized.length !== 16) { | ||
return false; | ||
} else { | ||
return true; | ||
} | ||
} | ||
|
||
module.exports = creditCardValidator; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const creditCardValidator = require("./creditCard-validator"); | ||
|
||
describe("creditCardValidator", () => { | ||
test("should return true for a 16 digit long card number", () => { | ||
expect(creditCardValidator("1234-5678-9012-3456")).toBe(true); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your tests all currently assume there are extra characters in the credit card number - is
123456789012345
valid? You may want to test that kind of thing too, to make sure your implementation doesn't assume there are separators.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I should have included tests for card numbers that are more or fewer than 16 digits. As you suggested, I created one test for the case of fewer and another for more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These extra tests look good, but aren't quite getting at the problem I was pointing at - can you add a test for a 16-digit credit card number which is only numbers (i.e. no spaces or
-
s)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I included a test for only 16 digits without spaces or operators.