London ITP- Jan25 | Shohreh Bayat | Onboarding-Form Control | Week 2 #194
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shohreh-bayat
added
the
Needs Review
Shohreh-bayat
changed the title
Shohreh-bayat
changed the title
SallyMcGrath
added
the
Review in progress
SallyMcGrath
left a comment
SallyMcGrath
left a comment
There was a problem hiding this comment.
Thanks for this @Shohreh-bayat . Let me know what you find out about the form validations and patterns.
Form-Controls/index.html
Outdated
| </div> | ||
| <div> | ||
| <label for="email">E-mail</label> | ||
| <input type="email" name="email" id="email" placeholder="e.g., user@example.com" pattern="^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$" size="30" required > <br> <br> |
There was a problem hiding this comment.
Goodness! This is a lot of validation. Tell me, what happens when you remove the pattern and test your form (by writing in a malformed email and hitting submit)?
There was a problem hiding this comment.
Hi Sally, Initially, I tried to use simpler validations like .+@example.com size="30" required
but in reality it was not allowing me to enter my own email address when I was testing the form, so I put this long validation to allow different email to be accepted e.g my own email address has underscore "_" on it, and with a simple pattern, the form would not accept that.
| <label for="email">E-mail</label> | ||
| <input type="email" name="email" id="email" placeholder="e.g., user@example.com" pattern="^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$" size="30" required > <br> <br> | ||
| </div> | ||
| </fieldset> <br> |
There was a problem hiding this comment.
What is this br tag trying to do?
| </fieldset> <br> | |
| </fieldset> |
There was a problem hiding this comment.
Hi Sally, I was trying to create space so that it shows better on the website. Considering that we are not allowed to use CSS,
tag was doing that for me.
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <fieldset> |
There was a problem hiding this comment.
Love the fieldsets, you legend! ⭐
SallyMcGrath
added
Reviewed
3 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.