Skip to content

London ITP- Jan25 | Shohreh Bayat | Onboarding-Form Control | Week 2 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

London ITP- Jan25 | Shohreh Bayat | Onboarding-Form Control | Week 2 #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e49556
Made all changes per read me file.
Shohreh-bayat Jan 20, 2025
448d7eb
edited placeholder for email
Shohreh-bayat Jan 20, 2025
89957d9
Add option -select- for colour
Shohreh-bayat Jan 20, 2025
60740d6
Added option" select a size" for Size section.
Shohreh-bayat Jan 20, 2025
29354d8
Edited option "select a size" added a > after option.
Shohreh-bayat Jan 20, 2025
5a1832b
Added select a colour to line 32, and select a size to line 41.
Shohreh-bayat Jan 20, 2025
bc29ce0
Pattern for email removed
Shohreh-bayat Jan 25, 2025
5d3adb5
A Meta description has been added
Shohreh-bayat Jan 25, 2025
8bb275e
Added aria-label to footer
Shohreh-bayat Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<title>Shohreh's form exercise</title>
<meta name="description" content="Product Pick" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
Expand All @@ -13,15 +13,47 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<fieldset>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the fieldsets, you legend! ⭐

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sally ⭐

<legend> Personal details </legend>
<div>
<label for="name">Name</label>
<input type="text" name="name" id="name" placeholder="type your full name" required minlength="2"> <br> <br>
</div>
<div>
<label for="email">E-mail</label>
<input type="email" name="email" id="email" placeholder="e.g., user@example.com" required > <br> <br>
</div>
</fieldset> <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this br tag trying to do?

Suggested change
</fieldset> <br>
</fieldset>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sally, I was trying to create space so that it shows better on the website. Considering that we are not allowed to use CSS,
tag was doing that for me.

<fieldset>
<legend>T-shirt information</legend>
<div>
<label for="colour"> Colour</label>
<select name="colour" id="colour" required>
<option value="select a colour"></option>
<option value="Red">Red</option>
<option value="Green">Green</option>
<option value="White"> White </option>
</select> <br><br>
</div>
<div>
<label for="size">Size</label>
<select name="size" id="size" required>
<option value="select a size"></option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M"> M </option>
<option value="L"> L </option>
<option value="XL"> XL </option>
<option value="XXL"> XXL</option>
</select>
</div>
</fieldset> <br>

<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Shohreh Bayat for CYF</h2>
</footer>
</body>
</html>
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ <h2><a href="/Form-Controls">Project 2: Form Controls</a></h2>
</li>
</ol>
</main>
<footer><a href="HOW_TO_REVIEW.md">HOW TO REVIEW MD</footer>
<footer><a href="HOW_TO_REVIEW.md" aria-label="Read more about how to review">HOW TO REVIEW MD</footer>
</body>
</html>