Approve pantry request #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah/add tables
Create initial routes to pages
Ot.food request form
Change favicon title
created and added header component to root
update donations table
…folder to deduplicate code
Food request form
Confirm food delivered and Request Forms Dashboard
… for application modal button
Pantry dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes Approve pantry request
📝 Description
I implemented the full functionality of the page for the ability to approve and deny pantry request. I added a modal button to each name that would display information about their application, a button to either approve or deny (which communicates and updates that to the backend), and a sorting option to filter (A-Z, Z-A, chronological, reverse chronological) the pantry names and application dates.
Briefly list the changes made to the code:
✔️ Verification
To verify these features, I created a few basic pantry entries manually in the database, and made sure that the pantry representative id was the id of a valid user (creating a new user manually as well if need be). I checked the buttons with the difference in pantry status before and after it was pressed.
🏕️ (Optional) Future Work / Notes
The only thing that may need future work is verification. As of right now, this is just a page anyone can access. Obviously, this page would need a login beforehand. Additionally, I had to disable the JWT authentication within the users backend so that I could easily get information of the user/pantry representative without having to do logging in. This is likely something that will be addressed later, but nothing that needs immediate attention as of now.