created and added header component to root #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-schu
reviewed
Oct 16, 2024
apps/frontend/components/Header.tsx
Outdated
| import React from 'react'; | ||
|
|
||
| const Header = () => { | ||
| return <h2>Securing Safe Food</h2>; |
There was a problem hiding this comment.
Is there a reason for using h2 instead of h1 if this is going to be the site heading? (This should be h1 for accessibility unless there is going to be a top-level heading somewhere else on the page.)
There was a problem hiding this comment.
I see, I didn't think much of it at the time and i'll make the change right now.
sam-schu
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://trello.com/c/i45MT3DO
📝 Description
I may have pushed to scaffolding on my first PR. I've included the header and the routing component
✔️ Verification