#19 Terraform Github Action bugs #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
This reverts commit fe338cd.
…Community/branch into 19-terraform-github-bugs
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
…Community/branch into 19-terraform-github-bugs
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
…Community/branch into 19-terraform-github-bugs
…Community/branch into 19-terraform-github-bugs
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
denniwang
changed the title
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
nourshoreibah
requested changes
Oct 8, 2025
There was a problem hiding this comment.
Looks good to me! Awesome work!! Since Yurika's tf apply workflow is working now, and we don't want to incur extra charges, could you please delete the contents of test/main.tf? we can leave it as an empty file for people to test plans but don't want to actually create any resources
This reverts commit 2c409d4.
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
…Community/branch into 19-terraform-github-bugs
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
nourshoreibah
approved these changes
Oct 9, 2025
|
And thank you for being so thorough w/ the tests and screenshots 🐐🐐 |
Terraform Plan 📖
|
Terraform Plan 📖
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #19
📝 Description
terraform plan now saves error logs in a text file and adds it to the comments of a pr
terraform plan comments also show the name of the person pushing
✔️ Verification
We verified this by making a pr that caused an error and didn't have descriptive logs. After making changes, we were able to see the logs.
We tested the comments updating to show the correct username by having Yurika pushing to my branch and the github action bot commented with her name instead of Nour's or mine.
Bug:
in GHA Workflow:
in PR Comment:
Resolved to:
in GHA Workflow:
in PR Comment:
Notes