-
Couldn't load subscription status.
- Fork 0
Labels
Description
User Story
As a dev, I want to have a working Terraform plan workflow so we can easily create infrastructure.
Description
The Terraform Plan workflow has 2 bugs:
- In the PR comment it makes after the plan, it writes pushed by: @nourshoreibah no matter who opened the PR. This is likely because it uses a PAT from Nour's account to change the ReadMe. Change the workflow to write Pushed By: {PR Opener} in the comment, or remove this portion of the comment if that is not possible.
- When the Terraform Plan errors, the PR comment says "check workflow for more details", but the logs for the plan do not appear in the workflow
This ticket is to fix these 2 bugs
Acceptance Criteria
Bug 1:
- Commit a small test change to a terraform workspace (ex. add an unused variable).
- The workflow will add the unused variable to the readme after you open a PR. It will then say pushed by: @nourshoreibah . Change the logic so it no longer does this, and instead says pushed by your username
Bug 2: - Recreate the error by making a PR with a syntax or other terraform error
- Confirm the PR workflow error output is not in the PR comment or workflow
- Modify the PR workflow so that the error output is in the Terraform Plan comment, instead of the message telling you to check the workflow for more details
- Change the workflow so that the logs are also visible during terraform plan. Redundancy is good here