Deprecation Warnings in Rails 5.1

[ryanb]

It looks like there are several issues about deprecation warnings which appear to be fixed, but unfortunately mine are not fixed with Closure Tree 7.0.0. I'm running Rails 5.1.6.

DEPRECATION WARNING: The behavior of changes inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use saved_changes instead. (called from update_org_node at ...)

The culprit appears to be this line which is calling changes.

[ryanb]

Turns out this isn't a problem with closure_tree, but with how Rails deprecation warning is scoped. I was saving a closure tree model through an after_save callback of a different model. Rails isn't smart enough to not display the deprecation warning when it is an after_save callback of a different model.