Skip to content

Still getting deprecation warnings on Rails 5.1 #269

Closed
@malacalypse

Description

@malacalypse

Running Rails 5.1, closure_tree 6.5.0

Not sure why, but I'm still getting deprecation warnings such as:

DEPRECATION WARNING: The behavior of `attribute_changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_change_to_attribute?` instead. (called from block (2 levels) in <class:CommentsControllerTest> at /Users/user/Development/app/test/controllers/some_controller_test.rb:6)

These come when creating a model with has_closure_tree. When I comment out that line in the model, the deprecation warnings cease. I get a warning for each of the following methods:

attribute_changed
attribute_changed?
changed
changes

There seems to be, at least on the master branch, already a workaround for changes in place but it doesn't seem to be triggering (yes my version of ActiveSupport is 5.1.0, I checked).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions