Repository navigation
fix(cmux): cover merged/closed PR tracking and update stale-stage caption - #419
Conversation
…tion Main's coverage gate failed after vitest 5.0.3 started counting the `??` fallbacks in selectTrackedPullRequest as separate functions, which no test reached. Add cases for a merged PR preferred over a closed one and a closed-only PR. The sidebar's stale caption still named the retired standalone poller; point it at `crew run --watch`, which now owns the sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDPWP8wH2WJjTPgZzibVG2
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe stale-stage warning and documentation now refer to ChangesStale-stage command reference
Pull-request selection tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The updated warning and documentation point to the watcher that refreshes PR stages, and the added tests cover the stated pull-request selection cases. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)
Comment |
…420) Stacked on #419 (main's coverage gate is red until it merges). ## Summary - Sidebar rows showed only `w.pr`, the first PR cmux reports for the workspace, so a task whose agent opened several PRs hid the rest. The second row line is now a vertical list: the ticket pill, then one `PR #N · status` line per entry in `w.prs`. - Sidebar test fixtures now set `prs` alongside `pr`, matching what cmux projects. New `listsEveryPullRequestOnItsOwnLineUnderTheTicket` case. - README layout description updated. ## Verification - 50 sidebar tests pass against a cmux checkout; the new case failed before the change. - Render benchmark: 282.1ms vs main's 281.7ms (DEBUG median). - `node --run verify` passes on top of #419. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01QDPWP8wH2WJjTPgZzibVG2 Co-authored-by: Test <test@example.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2 participants
Summary
prStageSync.tsat 90.47% functions (lines 164-165). vitest 5.0.3 (chore(deps): update vitest monorepo to v5.0.3 #418, merged just before) counts the??fallback callbacks inselectTrackedPullRequestas separate functions, and no test reached the merged or closed branches. Adds table cases for a merged PR preferred over a closed one, and a closed-only PR.Verification
node --run verifypasses locally on node 24.14.1, coverage back to 100%.selectTrackedPullRequestfails the new merged-over-closed case.🤖 Generated with Claude Code
https://claude.ai/code/session_01QDPWP8wH2WJjTPgZzibVG2