Add RRTMG #2
Closed
Add RRTMG #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
323: add gray sw optical depth r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add SW optical depth calculation for gray radiation ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Jan 19, 2023
326: Make docs strict r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #262 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Jan 31, 2023
327: Add docs: overview and RTE equations r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add overview and RTE to the docs. Closes #328. Note that I was trying to follow the code when there are discrepancies between the code and the paper. Please click on `documenter/deploy` at the bottom of this page to see the docs. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
330: Add equations for gray radiation r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #329 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 10, 2023
336: Adds gas optics to docs r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #331 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
340: Add documentation for cloud optics r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #332 Closes #333 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
341: Add documentation for examples r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> This PR adds some examples that are currently in `test` to the documentation. I think it can be significantly improved, for example, by having actual examples in the code and generating the documentation automatically. We can do it in the future. For now I just want to add some plots to the doc for the users to take a quick look. Closes #334 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
343: Clean up api in docs r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #342 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
344: fix docs for gray atmosphere optics r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Mar 1, 2023
345: Update README.md r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Mar 1, 2023
346: Bump minor version r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Bump minor version to 0.7.0 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Jun 16, 2023
357: change input to degrees r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Change to use latitude and longitude in degrees in the input. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Jun 16, 2023
358: Bump patch version r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing travis