Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docs strict #262

Closed
charleskawczynski opened this issue Jan 4, 2021 · 3 comments · Fixed by #269 or #326
Closed

Make docs strict #262

charleskawczynski opened this issue Jan 4, 2021 · 3 comments · Fixed by #269 or #326
Assignees
@szy21
Labels
documentation Improvements or additions to documentation

Comments

@charleskawczynski
Copy link
Member

Right now strict = false in docs/make.jl, which means that there are probably a lot of broken things in the docs. We should change this, as we have in ClimateMachine.jl, to strict = true
@charleskawczynski charleskawczynski added the documentation Improvements or additions to documentation label Jan 4, 2021
@charleskawczynski charleskawczynski mentioned this issue Mar 19, 2021
Merged
bors bot added a commit that referenced this issue Mar 19, 2021
@bors @charleskawczynski
Merge #269
3cb6883 
269: Fix broken documentation, make strict r=charleskawczynski a=charleskawczynski

Fixes #262

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors bors bot closed this as completed in 92874df Mar 19, 2021
@bors bors bot closed this as completed in #269 Mar 19, 2021
@charleskawczynski
Copy link
Member Author

See #270

@sriharshakandala
Copy link
Member

@charleskawczynski , @dennisYatunin ,
We have good documentation and code coverage. I believe this issue can be closed.

@charleskawczynski
Copy link
Member Author

I prefer we leave this issue open until we make the docs strict.

This was referenced Jan 19, 2023
Closed
Merged
@bors bors bot closed this as completed in eaa8a87 Jan 19, 2023
@szy21 szy21 self-assigned this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szy21 szy21

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken documentation, make strict CliMA/RRTMGP.jl
Make docs strict CliMA/RRTMGP.jl
3 participants
@charleskawczynski @szy21 @sriharshakandala