Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed atmic smarphone and intergrated AR unable to read stored books. #78831

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

SomeName42
Copy link

Summary

Bugfixes "Fixed atmic smarphone and intergrated AR unable to read stored books."

Purpose of change

Fixes #78245 and fixes #78615

Describe the solution

The cause of the error was that the atomic smartphone doesnt use or store energy and that the intergrated AR uses bionic energy stored in the carrier character. This was fixed by not checking energy on parent items that don't consume energy and by also getting the energy stored in the parent item carrier character."

Testing

I tested that books stored in the smartphone can be read only when it has enough energy, I also tested that books stored in the atomic smartphone can be read. Finally I also tested that books stored in the integrated AR can also be read only when the character has enough bionic power. I also suggest testing similar magical items and the Flawless memory item from Bombastic perk, but I think these should also work because they also dont consume energy similarly to the atomic smartphone.

…use of the error was that the atomic smartphone doesnt use or store energy and that the intergrated AR uses bionic energy stored in the carrier character. This was fixed by not checking energy on parent items that dont consume energy and by also getting the energy stored in the parent item carrier character.
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 29, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 29, 2024
@Maleclypse Maleclypse merged commit 0f6295e into CleverRaven:master Dec 30, 2024
24 of 27 checks passed
@MoonlightKitty26
Copy link

MoonlightKitty26 commented Dec 30, 2024

Unfortunately, the issue still persists for me even after doing a fresh install of the latest version and removing every mod. I appreciate y'all working on this!
(Is it possible that the latest version available doesn't have this PR included?)

OS: Windows
    OS Version: 10.0.19045.4651 (22H2)
Game Version: https://github.com/CleverRaven/Cataclysm-DDA/commit/8f6c5af7d40db4c39bdbfddc5e2443b9abbbfdd7 [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [
Dark Days Ahead [dda]
]

Integrated AR Test-trimmed.tar.gz

Screenshot (185)
Screenshot (186)
Screenshot (187)

@SomeName42
Copy link
Author

The version you tested doesn't include the fix yet commit 8f6c5af is from before the PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated AR Bionic doesn't store books Atomic Cell Phone can not read books [aftershock]
3 participants