fix: color tags texts drawn in item info #78784
Open
+10
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "color tags texts drawn in item info"
Purpose of change
Item info colour tags would render if they are the first character after a line wrap.
The bug also needed the window to be sufficiently high. That is why it is reproducible in
(
disassembly menu.Describe the solution
Don't draw the text when
textStart == drawEnd
. When the text starts with a color tag,textStart == drawEnd
is true.I don't really get the code. @db48x, as the author of that code, could you check if my change makes sense?
Describe alternatives you've considered
Waiting for somebody else. This took way too long.
Testing
Additional context