Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC snippets overhaul, part 3. talk_tags_line.json #77374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Uwuewsky
Copy link
Contributor

@Uwuewsky Uwuewsky commented Oct 27, 2024

Summary

None

Purpose of change

Continuation of #77372
Okay, what's here? talk_tags_line.json. git mv for some reason did not work the same way as for the three files in the second part, and defined these actions as deletion and creation of a new file.
This file breaks down into several components. Renewed <swear!>. Also reworked snippets of NPC reactions to smoke.
Otherwise, everything is the same.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions labels Oct 27, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • UEE HEE HEE!
  • Aaaaand nope.
  • Bananope.
  • Damnit<punc…!>
  • Fuckit<punc…!>
  • Nada.
  • Nope, ain't happenin'.
  • Nope, nada, never.
  • Not happenin' chief.
  • Oh, lordy<punc…!>
  • Shitballs!
  • SpIrAlS

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Oct 27, 2024
@Night-Pryanik Night-Pryanik reopened this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants