Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tileset id along with debug overmap info #75430

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

ehughsbaird
Copy link
Contributor

Summary

None

Purpose of change

#75236 (comment)

Describe the solution

Add the tileset id to the debug information provided.

Describe alternatives you've considered

I don't understand the other problem "current implementation ignoring overmap objects and use only first sprite of the object set". Could you elaborate @vetall812 ?

Testing

Debug teleport on the overmap, and look around at tiles:
image

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 3, 2024
@Maleclypse Maleclypse merged commit 5dca8af into CleverRaven:master Aug 4, 2024
23 of 28 checks passed
@ehughsbaird ehughsbaird deleted the show-om-tileset-id branch August 4, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants