Fixing issue where Android gesture inputs were broken #73554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
katemonster33
force-pushed
the
android_navigation_imgui
branch
from
3694d5b to
fab50dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixed issue where Android gesture inputs were not recognized by ImGui windows"
Purpose of change
Fixes: #73260
Describe the solution
I read up on what "input trickling" does after #73180 seemed to cause this issue and discovered that, if a key is pressed and released incredibly rapidly (which was how the "fake" gesture inputs looked to ImGui) then the input would be ignored.
So what I did was, send the fake input as a key pressed event to ImGui, then, at the end of the frame, I send the key released event. This way the input is not ignored.
Describe alternatives you've considered
Testing
Load Android build, open keybindings screen, verify that gestures work to scroll the keybindings list.
Additional context