Fixed collapse_check logic #72962
Merged
Fixed collapse_check logic #72962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #72960, e.g. the map::collapse_check logic being incorrect.
Describe the solution
Remove the static assignments in the loops with a single check at the top and bail out when a tree top is processed.
Describe alternatives you've considered
Leave it to someone else.
Testing
Chopped down a tree that had a tree top and verified the treetop was gone afterwards.
Then hacked the collapse check to return a really large number, virtually ensuring it would never roll a collapse and performed the tree chopping again. This time the treetop remained.
Additional context