[MoM] Update learning EoCs to reuse condition list #72080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Update learning EoCs to reuse condition list"
Purpose of change
#71956 allows EoCs to use condition lists from other EoCs, which means I can centralize MoM's thousands of lines of reused banned effects into a single
EOC_PSI_LEARNING_BANNED_EFFECTS
and just reference it a hundred times. So, I should do that in case I ever need to edit it.Describe the solution
Make
EOC_PSI_LEARNING_BANNED_EFFECTS
, replace the list in every individual power learning EoC with a reference to it.Describe alternatives you've considered
Testing
Started a game, buffed my starting powers to level 12, lived on protein rations and water for a few days, saw that I never learned any new powers. Turned on debug needs, waited for the gross food effect to wear off, learned a new power.
Additional context
Check out that added to deleted line ratio!