Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Update learning EoCs to reuse condition list #72080

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Feb 29, 2024

Summary

Mods "[MoM] Update learning EoCs to reuse condition list"

Purpose of change

#71956 allows EoCs to use condition lists from other EoCs, which means I can centralize MoM's thousands of lines of reused banned effects into a single EOC_PSI_LEARNING_BANNED_EFFECTS and just reference it a hundred times. So, I should do that in case I ever need to edit it.

Describe the solution

Make EOC_PSI_LEARNING_BANNED_EFFECTS, replace the list in every individual power learning EoC with a reference to it.

Describe alternatives you've considered

Testing

Started a game, buffed my starting powers to level 12, lived on protein rations and water for a few days, saw that I never learned any new powers. Turned on debug needs, waited for the gross food effect to wear off, learned a new power.

Additional context

Check out that added to deleted line ratio!

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 1, 2024
@Maleclypse Maleclypse merged commit 8a1fa0e into CleverRaven:master Mar 1, 2024
23 of 24 checks passed
@Standing-Storm Standing-Storm deleted the reusing-conditions branch March 1, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants