Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Some concentration powers were missing kcal cost + XP gain #71276

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[MoM] Some concentration powers were missing kcal cost + XP gain"

Purpose of change

As title. Some concentration powers were missing both the kcal cost for maintaining them and the XP bonus for same.

Describe the solution

Adding missing lines.

Describe alternatives you've considered

Testing

Loaded game, concentrated on a few of the appropriate powers, saw XP gains and no errors.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 26, 2024
@Maleclypse Maleclypse merged commit b960717 into CleverRaven:master Jan 27, 2024
19 of 24 checks passed
@Standing-Storm Standing-Storm deleted the add-missing-xp branch January 28, 2024 02:28
@Montimorency
Copy link
Contributor

Montimorency commented Jan 30, 2024

Oh sweeet, I had noticed the lack of leveling (after concentration leveling was added last year) a little while ago but assumed it was a nerf. That is, at first it seemed as though the experience gain might be much lower than with activations; I needed longer to realize that it was actually zero.

On that topic, Far Hand (possibly the most useful utility function ever modded into the game) used to pull objects as far as the power's level would allow, landing either adjacent to or under the player. E.g. if the max range was 10 at a given time, you could always bring items from 10 tiles away by or beneath your character. But at some point, it came about that Far Hand would no longer pull items more than either 6 or 7 tiles at a time under any circumstances - except with Nether Attunement present - even with the power maxed out at Level 18.

Is this intended?

@Standing-Storm
Copy link
Contributor Author

That sounds like a bug--Nether Attunement should change the maximum possible range, not the maximum effective range.

@Montimorency
Copy link
Contributor

Ah, but if the maximum effective range is capped to 7 now, what does the maximum nominal range represent?

@Standing-Storm
Copy link
Contributor Author

Hmm. Having just tested it, it is acting oddly--there shouldn't be any random factor, it should pull the target the entire distance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants