Fix maple tree in sugar house not responding to action #71242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
In the sugar house,
tapped_maple
were placed by mapgen and also bucket were placed there, but the spile was missing. This causedtree_maple_tapped
, which is an examine_action whentapped_maple
is used, to return without any processing if the spile is missing at that function part,iexamine::tree_maple_tapped
. As a result, it was not possible to insert the missing spile or remove the bucket ( it means that the terrain returns tot_tree_maple
), in other words, there was no way to execute any action.Now, putting to the spile, it is hoped that the action will be revived
, and the sap collection mechanism, as originally intended, will also begin to work.Without the presence of the spile ( as an item ), it seems that the mechanism of sap accumulating into the container still remains working ( meaning that sap will accumulate when the time is harvest, no matter if this PR is not applied ).
However, there is still no way to peaceful way to get the sap out of the container, as it remains inaccessible via actions, only by cutting down the tree into logs, allowing the container to be taken out.
In this case, bucketfuls of sap would require cutting down trees to gather it,
which is a bit unsustainable. As a more sustainable alternative,this fix is needed to avoid public accusations that the sugar house owner cut down a tree to collect a bucket of sap in the post-apocalyptic.Describe alternatives you've considered
t_tree_maple
instead of placingtapped_maple
, and keeping the buckets and spiles together nearby, and requiring the player to actively set up them.Testing
In-game testing was done. Actions can be performed on the maple tree in the sugar house and that maple sap is accumulated in auto-placed bucket during the harvest season.
Additional context
It seems to me that the amount of maple syrup left in the sugar house tanks is too little( about 5l? ).
Even kitchen in my house has 500 ml.