Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maple tree in sugar house not responding to action #71242

Merged

Conversation

EIIKaO
Copy link
Contributor

@EIIKaO EIIKaO commented Jan 25, 2024

Summary

None

Purpose of change

Describe the solution

In the sugar house, tapped_maple were placed by mapgen and also bucket were placed there, but the spile was missing. This caused tree_maple_tapped, which is an examine_action when tapped_maple is used, to return without any processing if the spile is missing at that function part, iexamine::tree_maple_tapped. As a result, it was not possible to insert the missing spile or remove the bucket ( it means that the terrain returns to t_tree_maple ), in other words, there was no way to execute any action.
Now, putting to the spile, it is hoped that the action will be revived , and the sap collection mechanism, as originally intended, will also begin to work.
Without the presence of the spile ( as an item ), it seems that the mechanism of sap accumulating into the container still remains working ( meaning that sap will accumulate when the time is harvest, no matter if this PR is not applied ).
However, there is still no way to peaceful way to get the sap out of the container, as it remains inaccessible via actions, only by cutting down the tree into logs, allowing the container to be taken out.
In this case, bucketfuls of sap would require cutting down trees to gather it, which is a bit unsustainable. As a more sustainable alternative, this fix is needed to avoid public accusations that the sugar house owner cut down a tree to collect a bucket of sap in the post-apocalyptic.

Describe alternatives you've considered

  • Placing t_tree_maple instead of placing tapped_maple, and keeping the buckets and spiles together nearby, and requiring the player to actively set up them.

Testing

In-game testing was done. Actions can be performed on the maple tree in the sugar house and that maple sap is accumulated in auto-placed bucket during the harvest season.

Additional context

It seems to me that the amount of maple syrup left in the sugar house tanks is too little( about 5l? ).
Even kitchen in my house has 500 ml.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 25, 2024
@EIIKaO
Copy link
Contributor Author

EIIKaO commented Jan 25, 2024

In my first commit in this PR, I defined the spile as an additional after the bucket.

"item": { "M": [ { "item": "bucket", "chance": 100 }, { "item": "tree_spile", "chance": 100 } ] },

In this case, the spile is overlay above the tree image.
show_spile

After submitting this PR, I found that the bucket would show up if I wrote the following
"item": { "M": [ { "item": "tree_spile", "chance": 100 }, { "item": "bucket", "chance": 100 } ] },
show_bucket

IMO, the spile are small and difficult to recognize on the screen. In contrast, buckets are large and easily recognizable. For this reason, I think that displaying the bucket may be a more suitable way to indicate that sap is being collected ( or ready to be collected ).
It is a very trivial point, but since it is unlikely that anyone will ever again care about this or even try to modify it, I will note it here in passing, and more, if there is any opinion that it would be preferable for the bucket to be displayed, I will modify it so.

@EIIKaO EIIKaO marked this pull request as ready for review January 25, 2024 21:48
@EIIKaO EIIKaO changed the title Fix maple trees in the sugar house not working Fix maple tree in sugar house not responding to action Jan 25, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 25, 2024
@Maleclypse Maleclypse merged commit 64f39f4 into CleverRaven:master Jan 26, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sugar house's tapped mapple trees do not work.
2 participants