Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kantele + Minor fixes #71118

Merged
merged 7 commits into from
Jan 21, 2024
Merged

Add Kantele + Minor fixes #71118

merged 7 commits into from
Jan 21, 2024

Conversation

ANickelN
Copy link
Contributor

Summary

Content "Adds kantele"

Purpose of change

Got to listen to one of these in person the other day, and felt like adding it to the game. More variety in instruments never hurt. Adds looks_like values to instruments after I noticed a lot of missing tiles playing with UltiCata.

Describe the solution

Adds the kantele, allowing it to spawn rarely in music stores and very rarely in house bedrooms.

Describe alternatives you've considered

Having a little less music in the world?

Testing

Loaded the game, spawned 15 music stores and found only 3 kantele.
Picked one up, it has correct weight and dimensions, playing it makes the proper text appear in the log.

image

image

Additional context

This might be a fun instrument for one of the magic mods to use. Kantele myth is heavily associated with spellcasting.

Not from pike's bone.
they can spawn in bedrooms with a very rare chance
chance from 5 to 10, found 3 kantele in 15 stores while testing
string: acoustic_guitar
wind: flute
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 20, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A traditional Finnish string instrument. According to myth the first one was fashioned from a great pike's bone. This ordinary wooden one doesn't seem quite as special.
  • kantele
  • kanteles

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 20, 2024
@Maleclypse Maleclypse merged commit 989247f into CleverRaven:master Jan 21, 2024
23 of 24 checks passed
@ANickelN ANickelN deleted the kantele branch February 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants