Handle nullptr in spawn-monsters-submap #70880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Handle nullptr in spawn-monsters-submap"
Purpose of change
Fix #70650.
When checking for missions attached to spawning monsters, the case where mission::find fails and returns a nullptr is not handled, presumably leading to a segmentation fault somewhere down the line.
Describe the solution
Add a check for null pointers before proceeding to operate on the returned mission. The debug message for failing to find the mission with the appropriate mission id has been intentionally left in since whatever is causing the failure would still be considered a (separate) bug, it just shouldn't cause a SIGSEGV now.
Describe alternatives you've considered
Testing
Game compiles, no longer segfaults.
Additional context