Initialize reset_item_vars #70713
Merged
Initialize reset_item_vars #70713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the migration did not explicitly set reset_item_vars to true of to false, the value remained uninitialized. I found this via -fsanitize=undefined reset_item_vars was introduced in 646fa4d. Based on the fact @irwiss decided to add this boolean switch and set it to true for several migrations I assume the intended default value is false.
github-actions
bot
added
[C++]
BrettDong
added
<Bugfix>
Merged
dseguin
added a commit
that referenced
this pull request
May 16, 2024
Procyonae
added
0.H Backported
and removed
0.H Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
If the migration did not explicitly set reset_item_vars to true or to false, the value remained uninitialized.
I found this via -fsanitize=undefined
reset_item_vars was introduced in 646fa4d. Based on the fact @irwiss decided to add this boolean switch and set it to true for several migrations I assume the intended default value is false.
Describe the solution
Always initialize reset_item_vars to false
Testing
-fsanitize=undefined no longer reports the error