Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appease clang-tidy check readability-static-accessed-through-instance #69233

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Appease clang-tidy check readability-static-accessed-through-instance #69233

merged 2 commits into from
Nov 10, 2023

Conversation

BrettDong
Copy link
Member

@BrettDong BrettDong commented Nov 10, 2023 •
edited
Loading

Summary

None

Purpose of change

Cataclysm-DDA/src/cata_tiles.cpp:4824:63: error: static member accessed through instance [readability-static-accessed-through-instance,-warnings-as-errors]
            iter->getStep() >= SCT.iMaxSteps / 2 );
                               ^~~~
                               scrollingcombattext::

Describe the solution

Make code comply with readability-static-accessed-through-instance. However, after fixing readability-static-accessed-through-instance, clang-tidy complains about modernize-loop-convert, so need to fix that too.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 10, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 10, 2023
@akrieger akrieger merged commit 3a04c3f into master Nov 10, 2023
26 checks passed
@BrettDong BrettDong deleted the readability-static-accessed-through-instance branch November 11, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettDong @akrieger