Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Proficiency and Skill training speed option #67925

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

lispcoc
Copy link
Contributor

@lispcoc lispcoc commented Aug 28, 2023

Summary

Interface "Separate Proficiency and Skill training speed option"

Purpose of change

Skill training speed option in debug menu changes both Skill and Proficiency training speed.
Ideally, skill and proficiency are elements of the set, so this is not a problem.
However, in reality, both are elements of the adjustment stage, so it happens that the skill training speed is too fast as a result of adjusting the proficiency training speed appropriately.

Describe the solution

Separate Skill training speed options into Skill and Proficiency to find the appropriate ratio.

Describe alternatives you've considered

Testing

Practice "athlete's form (expert)"

Set Skill training speed to 0.0, Proficiency training speed to 100.

  • Skill does not grow at all.
  • Proficiency grows very fast.

Set Skill training speed to 100, Proficiency training speed to 0.0.

  • Proficiency does not grow at all.
  • Skill grows very fast.

Set Skill training speed to 1.0, Proficiency training speed to 0.5

  • Skill grows 2 to 3 in about 2 hour
  • Athlete's Form proficiency grows 12% per an hour

Set Skill training speed to 1.0, Proficiency training speed to 1.0

  • Skill grows 2 to 3 in about 2 hour
  • Athlete's Form proficiency grows 24% per an hour

Set Skill training speed to 1.0, Proficiency training speed to 2.0

  • Skill grows 2 to 3 in about 2 hour
  • Athlete's Form proficiency grows 48% per an hour

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 28, 2023
@lispcoc lispcoc marked this pull request as ready for review August 28, 2023 01:35
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 28, 2023
@PatrikLundell
Copy link
Contributor

I'd prefer "separate" rather than "divide", as I had some trouble understanding what the issue was about (thoughts along the line of "divide by 2", i.e. reducing the rate).

Otherwise, I'd like to see a couple of tests verifying that changing the rates actually takes effects apart from the extremes of turning them off and turning them on (although I don't expect the tests to fail).

@lispcoc lispcoc changed the title Divide Proficiency and Skill training speed option Separate Proficiency and Skill training speed option Aug 28, 2023
@lispcoc lispcoc force-pushed the divide_skill_speed branch from 9574982 to 96c0cc0 Compare August 28, 2023 14:34
@ashGlaw
Copy link
Contributor

ashGlaw commented Aug 29, 2023

I'm blown away by how small of a change this took. Excellent idea

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 30, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 30, 2023
@Rivet-the-Zombie Rivet-the-Zombie merged commit 94171ef into CleverRaven:master Aug 31, 2023
@lispcoc lispcoc deleted the divide_skill_speed branch August 31, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants