Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed randomization of monster special attack cooldown during monster generation and loading of save #67022

Closed
wants to merge 2 commits into from

Conversation

WhiteCloud0123
Copy link
Contributor

@WhiteCloud0123 WhiteCloud0123 commented Jul 19, 2023

Summary

None

Purpose of change

Fix #64907

Describe the solution

When a monster is first generated, the special attack cooldown uses the JSON defined value. When loading save, the values are also not being randomized in a range.

Describe alternatives you've considered

Testing

Special attack cooldown was tested before and after loading the save and the results met expectations.

Picture 1 shows that when a monster is first generated, zombie launched an attack.The cooldown time for special attacks is correct.
ET`WVPD8FPL%W{0K)_V4){5
Picture 2 shows that after loading the save, zombie launched an attack.The cooldown time for monster special attacks is correct.
(T)D9R9}C TJ9U9V3T K8

Additional context

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jul 19, 2023
@WhiteCloud0123 WhiteCloud0123 marked this pull request as draft July 19, 2023 12:44
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 19, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 19, 2023
@WhiteCloud0123 WhiteCloud0123 marked this pull request as ready for review July 19, 2023 13:51
@WhiteCloud0123 WhiteCloud0123 changed the title Fixed the cooldown for monster special attacks on first use Fixed randomization of monster special attack cooldown during monster generation and loading of save Jul 19, 2023
@WhiteCloud0123
Copy link
Contributor Author

WhiteCloud0123 commented Jul 20, 2023

This may involve feedback related to monster battles in the game, and the experience brought about by such modifications also requires stable investigation. The author's original intention also needs to be carefully distinguished and clarified, so close it.

@WhiteCloud0123 WhiteCloud0123 deleted the fix-03 branch July 20, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monster special attacks' cooldown is randomised on first use
1 participant