Smooth out npc fear based on player strength #65151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The effect of player strength on NPC fear is weirdly granular, with a jump from -1 to -3, and different range size for each value.
Describe the solution
Replace the list of conditions with simple arithmetic. High strength effects are mostly unchanged. Low strength effects are changed slightly.
Describe alternatives you've considered
Testing
ran test suite, talked to some NPCs with different characters and didn't see unusual fear responses
Additional context