Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Recipes - All Batteries #60199

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Conversation

ANickelN
Copy link
Contributor

@ANickelN ANickelN commented Aug 16, 2022

Summary

Interface "Nested Recipes - All Batteries"

Purpose of change

Nest batteries, you get the drill by now.

Describe the solution

Add necessary json.

Division is:

Batteries -> Categories -> Item

Describe alternatives you've considered

AHHHHHHH

Testing

cataclysm-tiles_TswyhbXrPg

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 16, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 16, 2022
@ANickelN ANickelN marked this pull request as ready for review August 16, 2022 05:07
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 16, 2022
@RelMayers
Copy link
Contributor

RelMayers commented Aug 16, 2022

I see no reason to nest batteries so much. Single category would work better.

@irwiss
Copy link
Contributor

irwiss commented Aug 16, 2022

May be not a single category, but having a menu with just 2 items (and unlikely to ever grow a third) is just adding to already tedious menus in game.

Even on small android screens you can see about 14 items in crafting screen before needing to scroll and category count in single digits seems reasonable to have in a single menu

@esotericist
Copy link
Contributor

i too feel this is going a bit too excessive. the nesting feature has merit for de-cluttering the base list, but multiple layers deep is unnecessary and just adds more navigation overhead.

i would probably have a small number of base entries in the main list with a number of entries in them that don't nest further

@descan
Copy link
Contributor

descan commented Aug 16, 2022

I wouldn't nest the categories any deeper than "Rechargeable" and "Disposable," myself. Even that might be more needless clicking than just "Batteries" as the base and only category. There aren't that many batteries, after all.

@ANickelN
Copy link
Contributor Author

Thank you for the feedback! I've adjusted the nesting accordingly and hope this makes it feel less clunky!

@dseguin dseguin merged commit 2c4f10d into CleverRaven:master Aug 17, 2022
@ANickelN ANickelN deleted the nestedbatteries branch August 17, 2022 01:55
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
* Hide parts.json recipes

* Hide battery recipes toolmod.json

* Update parts.json

* Update toolmod.json

* hide recipes power_supplies.json

* Update nested.json

* fin

* lint or die

* implement feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants