Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cs_city_dump_small.json #56556

Conversation

mx-moonling
Copy link
Contributor

Summary

Content "Makes most furniture in the small dump be placed randomly when the map square is generated, as well as adding freezers to the pool (useful new appliance)."

Purpose of change

Freezers are currently only available in ice-cream stores. This change makes freezers somewhat easier to find, and also makes each dump more unique, without changing the core structure. It also now is easier to add other furniture to the pool that can spawn, for use in mods or when adding new appliances.

Describe the solution

This modifies the small dump mapgen to generate random furniture from a weighted list on tiles marked as an asterisk.

Describe alternatives you've considered

Building a static dump mapgen that includes freezers and does not otherwise change the layout.
Making a more complex series of weights for the various furnitures that can spawn.

Testing

Created new world with minimal mods, found a city, observed the new contents of the dump.

Additional context

Makes most furniture in the small dump be placed randomly when the square is generated, as well as adding freezers (useful new appliance).

Does not touch couches or bathtubs to preserve their multi-tile appearance, does not touch one of the trashcans, the dumpsters, the barricades or the bulletin board because they are part of the site, and not in the dump.
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Apr 3, 2022
@Night-Pryanik
Copy link
Contributor

Please run linter through your changes, for example via http://dev.narc.ro/cataclysm/format.html.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 3, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 3, 2022
@NetSysFire NetSysFire added the Spawn Creatures, items, vehicles, locations appearing on map label Apr 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 3, 2022
@Maleclypse Maleclypse added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Apr 3, 2022
@kevingranade kevingranade merged commit 1f4476f into CleverRaven:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants