Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a very low freezing_point for spice #37826

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Feb 8, 2020

Summary

SUMMARY: None

Purpose of change

Since the spice is a powder it shouldn't freeze.
This fixes the following issue:
Not all recipes with salt use heat. E.g. rehydration drink.
You cannot craft it with a frozen salt (but can use frozen sugar).

Describe the solution

Set a very low freezing_point for spice.

Describe alternatives you've considered

None.

Testing

After some time in game all frozen spices are cold in the same conditions where they were frozen.

Additional context

Items with "freezing_point": -490: paper, cardboard and fried seeds.

@AMurkin AMurkin requested a review from KorGgenT February 8, 2020 10:26
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Feb 8, 2020
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 8, 2020

I mean, isn’t salt only consumable frozen? Liquid salt would be so hot it would melt you. Good idea, makes sense 👍🏻

@KorGgenT
Copy link
Member

KorGgenT commented Feb 8, 2020

shouldn't salt just not "freeze"?

@AMurkin AMurkin force-pushed the add-flag-edible-frozen branch from 7946b4f to 62c8b0f Compare February 8, 2020 19:11
@AMurkin
Copy link
Contributor Author

AMurkin commented Feb 8, 2020

Yes. That's what it needs to be.

@AMurkin AMurkin changed the title Add EDIBLE_FROZEN flag to the salt item Set a very low freezing_point for spice Feb 8, 2020
@ZhilkinSerg ZhilkinSerg merged commit 346877f into CleverRaven:master Feb 9, 2020
@AMurkin AMurkin deleted the add-flag-edible-frozen branch February 9, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants